Add postCodeReviewResults.sh to claude-review-toolkit#66
Closed
kacper-mikolajczak wants to merge 1 commit into
Closed
Add postCodeReviewResults.sh to claude-review-toolkit#66kacper-mikolajczak wants to merge 1 commit into
kacper-mikolajczak wants to merge 1 commit into
Conversation
Centralises the violations post-processing loop currently duplicated across Expensify/App, Expensify/Auth, and Expensify/Web-Expensify's claude-review.yml workflows. The script reads STRUCTURED_OUTPUT from env, adds a +1 reaction when there are no violations, and otherwise posts one inline comment per violation via createInlineComment.sh.
This was referenced May 25, 2026
Contributor
Author
|
Superseded by #68 (consolidated slice 2 work into one PR per repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds a new helper script to the
claude-review-toolkitcomposite action that centralises the violations post-processing loop currently duplicated across the three clientclaude-review.ymlworkflows (Expensify/App,Expensify/Auth,Expensify/Web-Expensify).Behaviour preserved exactly:
STRUCTURED_OUTPUTfrom env, takesPR_NUMBERas positional argaddPrReaction.sh "$PR_NUMBER" "+1"createInlineComment.shcalls (one per violation, individual failures swallowed with|| true)STRUCTURED_OUTPUT->::error::annotation + exit 1PR_NUMBERrejected)After this lands, the three client workflows can replace their inline
jq+ while-loop block with a singlepostCodeReviewResults.sh "$PR_NUMBER"call. The client adoption PRs follow this one.This is slice 2 of the centralisation effort tracked in https://github.com/Expensify/Expensify/issues/635397.
Related Issues
https://github.com/Expensify/Expensify/issues/635397
Manual Tests
Smoke-tested locally with mocked
addPrReaction.sh/createInlineComment.shonPATH:+1reaction callSTRUCTURED_OUTPUT->::error::+ exit 1PR_NUMBER-> error + exit 1PR_NUMBER-> usage + exit 1End-to-end exercise comes from the client adoption PRs (linked below) running on real PRs of this repo.
Linked PRs
Client adoption PRs (drafts; reference this PR by placeholder SHA, re-stamped on merge):