fix(isbn13): update ISBN-13 generation logic and examples#1052
Open
Hikingyo wants to merge 2 commits into
Open
fix(isbn13): update ISBN-13 generation logic and examples#1052Hikingyo wants to merge 2 commits into
Hikingyo wants to merge 2 commits into
Conversation
Hikingyo
force-pushed
the
1051_ibsn13_and_ismn
branch
from
6effca0 to
84d71d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
FakerPHP/fakerphp.github.io#119
Summary of changes
Bug fix
isbn13()could generate codes starting with9790, which is the reservedprefix for ISMN (International Standard Music Number), not ISBN-13.
The generation logic now correctly restricts the
979prefix range to9791–9799.New feature
A dedicated
ismn()method has been added to generate valid ISMN codes(prefix
9790+ 8 digits + EAN-13 checksum).Review checklist
CHANGELOG.md