fix: use Node.js 22 in Nix flake#1177
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaces Node.js 20 with Node.js 22 in the Nix flake (build and dev shell inputs) and in GitHub Actions workflow job configurations. ChangesNode.js Version Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
flake.nix (1)
58-58: ⚡ Quick winUpdate specification document to reflect Node.js 22.
The Nix flake support specification at
openspec/changes/archive/2026-01-07-add-nix-flake-support/specs/nix-flake-support/spec.md(lines 47-73) explicitly states "The system SHALL use Node.js 20 as specified in package.json engines field" and referencesnodejs_20in scenarios. This documentation is now outdated and inconsistent with the actual implementation.Update the spec document to reflect the Node.js 22 requirement.
Also applies to: 100-100
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@flake.nix` at line 58, The spec currently asserts "The system SHALL use Node.js 20" and references nodejs_20; update the specification text and all scenario references to reflect Node.js 22 by replacing "Node.js 20" and nodejs_20 with "Node.js 22" and nodejs_22, and also update any mention of the package.json engines field to match Node.js 22 so the document aligns with the flake change (nodejs_22).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@flake.nix`:
- Line 58: The CI workflow uses Node.js 20 while the flake uses nodejs_22;
update the GitHub Actions workflow (.github/workflows/ci.yml) to match by
changing the setup-node/node-version or matrix value from 20 to 22 so CI and the
Nix flake (nodejs_22) use the same Node.js version consistently.
---
Nitpick comments:
In `@flake.nix`:
- Line 58: The spec currently asserts "The system SHALL use Node.js 20" and
references nodejs_20; update the specification text and all scenario references
to reflect Node.js 22 by replacing "Node.js 20" and nodejs_20 with "Node.js 22"
and nodejs_22, and also update any mention of the package.json engines field to
match Node.js 22 so the document aligns with the flake change (nodejs_22).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Summary
Why
Node.js 20 is now marked insecure in nixpkgs after reaching EOL, which causes Nix evaluation/builds to fail for OpenSpec users.
Fixes #1119.
Validation
Summary by CodeRabbit