Skip to content

fix: use generic progress tracking in prompts#1180

Open
leno23 wants to merge 1 commit into
Fission-AI:mainfrom
leno23:codex/fix-generic-progress-tracking-prompts
Open

fix: use generic progress tracking in prompts#1180
leno23 wants to merge 1 commit into
Fission-AI:mainfrom
leno23:codex/fix-generic-progress-tracking-prompts

Conversation

@leno23

@leno23 leno23 commented Jun 5, 2026

Copy link
Copy Markdown

Summary

  • replace TodoWrite-specific progress tracking instructions in propose and fast-forward workflows
  • use runtime-neutral guidance for native planning or visible checklists
  • add template coverage to keep TodoWrite references out of those workflows

Why

The generated fast-forward/propose prompts can reference a tool that is not available in some Claude Code environments. The workflow only needs progress tracking, so generic wording is enough and works across adapters.

Fixes #643.

Validation

  • pnpm exec vitest run test/core/templates/skill-templates-parity.test.ts

Summary by CodeRabbit

Release Notes

  • Improvements
    • Enhanced artifact creation progress tracking during workflow operations. The agent now uses its native planning and checklist mechanism to display progress, providing clearer visibility into the artifact creation process.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a391ec5-ec23-40e2-81ec-93ef293165c9

📥 Commits

Reviewing files that changed from the base of the PR and between 1b06fdd and 9117584.

📒 Files selected for processing (3)
  • src/core/templates/workflows/ff-change.ts
  • src/core/templates/workflows/propose.ts
  • test/core/templates/skill-templates-parity.test.ts

📝 Walkthrough

Walkthrough

This PR replaces references to the deprecated TodoWrite tool with instructions to use the agent's native planning/checklist mechanism across workflow templates. The ff-change and propose skill/command templates are updated with new progress-tracking guidance, test baselines are refreshed, and a new validation test ensures the templates contain the new mechanism and exclude TodoWrite references.

Changes

TodoWrite Tool Replacement in Workflow Templates

Layer / File(s) Summary
ff-change workflow template updates
src/core/templates/workflows/ff-change.ts
Updated skill template (line 45) and command template (line 148) instructions to track artifact progress using native planning/checklist mechanism instead of TodoWrite tool.
propose workflow template updates
src/core/templates/workflows/propose.ts
Updated skill template (line 54) and command template (line 166) instructions with the same progress-tracking mechanism change.
Test baseline updates and validation
test/core/templates/skill-templates-parity.test.ts
Refreshed SHA-256 baseline hashes for template factories and generated skill content, and added new test that validates templates include native planning/checklist guidance and exclude TodoWrite tool references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Fission-AI/OpenSpec#448: Introduced the /opsx:ff fast-forward skill/command templates whose instruction text is now being updated to remove TodoWrite tool references in this PR.

Suggested reviewers

  • TabishB

Poem

🐰 TodoWrite's gone, a tool of the past,
But checklists and planning shall forever last,
Native and nimble, the templates now sing,
Artifacts tracked without a deprecated thing! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: replacing TodoWrite-specific progress-tracking instructions with generic progress tracking in workflow prompts.
Linked Issues check ✅ Passed The changes directly address issue #643 by removing TodoWrite references from propose and fast-forward workflows and replacing them with generic progress-tracking guidance.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective: updating workflow prompts to use generic progress tracking instead of TodoWrite, with corresponding test updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leno23 leno23 marked this pull request as ready for review June 5, 2026 10:04
@leno23 leno23 requested a review from TabishB as a code owner June 5, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fast forward command instructs to use TodoWrite tool but claude no longer has it

1 participant