fix(validate): support workspace planning homes and nested delta specs#1186
fix(validate): support workspace planning homes and nested delta specs#1186XiaojuCH wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe validate command now resolves changes and specs via planning-home scoping, supporting both repo and workspace planning homes. Item discovery is refactored to extract planning-home–scoped helpers, and delta spec discovery becomes recursive to support nested spec structures within multi-area schemas. ChangesPlanning-home–aware validation with nested spec support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
Reviewed the diff and focused validation paths. The fix shape looks right: top-level validate now resolves through the current planning home, nested delta specs are discovered recursively, and directory-based change discovery is consistent with the workspace-planning direction.
Focused gates passed locally: pnpm install --frozen-lockfile, then pnpm exec vitest run test/commands/validate.test.ts test/core/validation.test.ts.
Fixes #1182.
This PR makes top-level
openspec validatework correctly for workspace-planning changes created from a workspace root.What changed:
validateresolve change paths through the current planning home instead of assuming repo-localopenspec/changesproposal.mdspecs/<area>/<capability>/spec.mdvalidate <change>andvalidate --changesfrom the workspace rootWhy:
status/instructions/new changealready resolve workspace planning homes correctlyvalidatewas the odd one out and returnedUnknown item '<change>'from the same workspace rootValidation:
node build.jsnode node_modules/vitest/vitest.mjs run test/commands/validate.test.tsnode node_modules/vitest/vitest.mjs run test/commands/artifact-workflow.test.ts --testNamePattern "nested workspace-planning specs"Summary by CodeRabbit
New Features
Bug Fixes