[5637] Upgrade hericons to v 2.1.5#7308
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7308 +/- ##
=======================================
Coverage 76.61% 76.61%
=======================================
Files 405 405
Lines 20602 20602
Branches 4986 4986
=======================================
Hits 15784 15784
Misses 4818 4818
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| function loadOutlineIcons () { | ||
| outlineIconsPromise ??= import('@heroicons/vue/24/outline') | ||
| return outlineIconsPromise | ||
| } |
There was a problem hiding this comment.
So, the old code lazy-loaded each icon. Heroicons v2's exports field broke that, and …/esm/${name}.js didn't work either.
Both tiles (this and BlueprintTileSmall.vue) now lazy-load the whole outline namespace as one dynamic import, webpack splits it into its own chunk, so the ~20 KB loads on demand instead of inflating main.js. loadOutlineIcons is at module scope so all tiles share one fetch. Tried a few different things here lmk if there is a better solution.
Description
See details here.
Related Issue(s)
Resolves #5637
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel