Skip to content

[5637] Upgrade hericons to v 2.1.5#7308

Open
n-lark wants to merge 6 commits into
mainfrom
5637-heroicons
Open

[5637] Upgrade hericons to v 2.1.5#7308
n-lark wants to merge 6 commits into
mainfrom
5637-heroicons

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented May 19, 2026

Description

See details here.

Related Issue(s)

Resolves #5637

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (7f9c612) to head (2b9a584).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7308   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         405      405           
  Lines       20602    20602           
  Branches     4986     4986           
=======================================
  Hits        15784    15784           
  Misses       4818     4818           
Flag Coverage Δ
backend 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

function loadOutlineIcons () {
outlineIconsPromise ??= import('@heroicons/vue/24/outline')
return outlineIconsPromise
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the old code lazy-loaded each icon. Heroicons v2's exports field broke that, and …/esm/${name}.js didn't work either.

Both tiles (this and BlueprintTileSmall.vue) now lazy-load the whole outline namespace as one dynamic import, webpack splits it into its own chunk, so the ~20 KB loads on demand instead of inflating main.js. loadOutlineIcons is at module scope so all tiles share one fetch. Tried a few different things here lmk if there is a better solution.

@n-lark n-lark requested a review from cstns May 20, 2026 18:14
@n-lark n-lark marked this pull request as ready for review May 20, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade hericons to v 2.1.5

1 participant