Skip to content

fix(FileLogger): transfert flushing option #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 4 commits into from
May 18, 2026
+97 −44
Merged

fix(FileLogger): transfert flushing option #1273

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b94f4e
fix(FileLogger): transfert flushing option
francoisbonneau May 18, 2026
836a348
typo
francoisbonneau May 18, 2026
d8aa68f
enrich test
francoisbonneau May 18, 2026
9d29740
tidy
francoisbonneau May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/geode/basic/file_logger_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <geode/basic/file_logger_client.hpp>

// clang-format off
#include <spdlog/spdlog.h>

Check failure on line 27 in src/geode/basic/file_logger_client.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/basic/file_logger_client.cpp:27:10 [clang-diagnostic-error] 

'spdlog/spdlog.h' file not found

#include <spdlog/sinks/basic_file_sink.h>
// clang-format on
Expand All @@ -46,14 +46,19 @@
void always_flush()
{
logger_impl_->flush_on( spdlog::level::level_enum::trace );
always_flush_ = true;
}

void set_file_path( std::string_view file_path )
{
static constexpr auto logger_name = "geode_logger_file";

Check warning on line 54 in src/geode/basic/file_logger_client.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/basic/file_logger_client.cpp:54:35 [readability-identifier-naming] 

invalid case style for constexpr variable 'logger_name'
spdlog::drop( logger_name );
logger_impl_ = spdlog::basic_logger_mt(
logger_name, std::string( file_path ) );
if( always_flush_ )
{
always_flush();
}
}

void trace( const std::string &message )
Expand Down Expand Up @@ -88,6 +93,7 @@

private:
std::shared_ptr< spdlog::logger > logger_impl_{ nullptr };
bool always_flush_{ false };
};

FileLoggerClient::FileLoggerClient( std::string_view file_path )
Expand Down
Loading