Install ZFP filter shared library to lib/plugin instead of plugin#270
Open
lrknox wants to merge 2 commits into
Open
Install ZFP filter shared library to lib/plugin instead of plugin#270lrknox wants to merge 2 commits into
lrknox wants to merge 2 commits into
Conversation
H5Z-ZFP/src/CMakeLists.txt (vendored via subtree) hardcodes the shared plugin's install destination to plugin, instead of following this project's lib/plugin convention. Relocate the installed file at install time so libh5zzfp.so lands in /lib/plugin like every other filter, without patching the vendored subtree.
Collaborator
Author
|
Additional fix needed for a packaging test failure on ubuntu. |
CPack (e.g. the DEB generator used by the Ubuntu CI job) stages
installs into while leaving CMAKE_INSTALL_PREFIX at its
literal configured value. install(TARGETS)/install(FILES) handle this
automatically via the DESTDIR-aware file(INSTALL), but the plain
file(MAKE_DIRECTORY)/file(RENAME) calls added to relocate libh5zzfp.so
did not, so packaging tried to create/rename outside the staging tree
and failed with 'No such file or directory'. Prepend {DESTDIR} by
hand to match.
Collaborator
Author
|
All tests now pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H5Z-ZFP/src/CMakeLists.txt (vendored via subtree) hardcodes the shared plugin's install destination to plugin, instead of following this project's lib/plugin convention. Relocate the installed file at install time so libh5zzfp.so lands in /lib/plugin like every other filter, without patching the vendored subtree.