Skip to content

Update course review#32

Open
LiPu-jpg wants to merge 2 commits into
mainfrom
pr-server/4bd36e4b-0aec-44e5-bb98-ccb085247907
Open

Update course review#32
LiPu-jpg wants to merge 2 commits into
mainfrom
pr-server/4bd36e4b-0aec-44e5-bb98-ccb085247907

Conversation

@LiPu-jpg

Copy link
Copy Markdown
Contributor

Updated via pr-server

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appends a new course review for '声乐理论与实践' (Voice Theory and Practice) to the end of the readme.toml file. However, the review comment correctly points out that appending [[sections]] at the end of the file violates the expected TOML schema and associates the review with the wrong course. The review block should be moved to the existing course section for '声乐理论与实践' as a new [[courses.sections.items]] block.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread readme.toml
Comment on lines +322 to +333
[[sections]]
title = "课程评价"
[[sections.items]]
content = """
对于想学习/练习发声技巧和气息的同学,这门课还是很值得报的。
每节课会有40分钟以上的时间练声,经常有老生过来一起练习。课堂会抽人识简谱(1234567),如果不会的话可能会比较尴尬,不过老师也不会追究什么。
学期中(比较靠前)和期末会各有一次上台单人展示的机会,使用麦克风和伴奏。第一次用于找感觉/给建议,第二次是正式的期末考核,都是任选曲目,最好要能不看歌词。
一周有四个班,如果缺勤了可以去其他班补。老生也可以回来旁听/练习。
总体而言,对于想学的同学是一门好课。
作为你校少有的艺术类课程,声乐理论与实践切切实实的给我带来了放松与快乐。上了这门课之后,自己平时唱歌也更不容易累了。
"""
author = { name = "软糯", link = "", date = "2026-06" } No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The review content explicitly mentions 声乐理论与实践 (Voice Theory and Practice), which is already defined as a course on line 87.

Currently, this review is appended at the end of the file (after the '碳达峰碳中和的中国之道' course) under [[sections]] and [[sections.items]]. This has two issues:

  1. Invalid/Incorrect Keys: The schema uses [[courses.sections]] and [[courses.sections.items]]. Using [[sections]] at the top level is incorrect.
  2. Incorrect Association: Placing it here associates it with the wrong course or breaks the parser.

Recommendation:
Move this review block to the existing 声乐理论与实践 course section, specifically appending it as a new [[courses.sections.items]] after line 101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant