Fix boundary to respect logical priorities#499
Merged
jorgesg82 merged 1 commit intodevelopmentfrom Mar 19, 2025
Merged
Conversation
g0nz4I0
approved these changes
Mar 19, 2025
Member
g0nz4I0
left a comment
g0nz4I0
left a comment
There was a problem hiding this comment.
I don't know how it would be misinterpreted by the compiler though, but it fixes it so go ahead
jmaralo
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A check in protections wasn't respecting logical priorities, as C++ doesn't respect them by default, because
andoperation has the most priority. This results as a warning when compiling, preventing compilation with warnings as errors.