Center Aligned#503
Merged
g0nz4I0 merged 5 commits intodevelopmentfrom May 3, 2025
Merged
Conversation
g0nz4I0
reviewed
Apr 18, 2025
Contributor
Author
|
@g0nz4I0 Yes I used the oscilloscope to tested, If I understand your comment, your complaining about the boolean to change a single PWM to phased?? |
jmaralo
requested changes
Apr 30, 2025
Member
jmaralo
left a comment
jmaralo
left a comment
There was a problem hiding this comment.
there are a few changes you made that make no sense, if they are to support center aligned PWMs you should add a new if instead of modifying the PHASED configuration
Member
|
Also add support for center aligned dual PWMs |
g0nz4I0
reviewed
May 3, 2025
g0nz4I0
previously approved these changes
May 3, 2025
jmaralo
approved these changes
May 3, 2025
g0nz4I0
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To center Aligned the pwms of a timer if we use phased instead of Normal. Added a boolean to check if is phased and multiply the freq to don't change the value