Fix ruff lint violations introduced by PR #13 (ar-r82f.22)#16
Merged
Conversation
Auto-fixed two ruff violations introduced by PR #13: - freewheel_adapter.py: I001 unsorted imports (alphabetized) - freewheel_oauth.py: W292 missing trailing newline Also ran `ruff format` on both files for consistency; this reflowed two short multi-line calls in freewheel_adapter.py and re-wrapped one call in freewheel_oauth.py. No logic changes. Unblocks PR #15 (ar-r82f.16) — seller CI workflow fix needs main's Lint job to pass so verification can reach pytest. bead: ar-r82f.22 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two auto-fixable ruff violations were introduced into
mainby PR #13 (FreeWheel OAuth PKCE migration). They block the Lint CI job, which in turn blocks PR #15 (the seller CI workflow fix) from reaching its pytest step in verification.This PR fixes both with
ruff check --fix+ruff format:src/ad_seller/clients/freewheel_adapter.py— I001 unsorted imports (alphabetized)src/ad_seller/clients/freewheel_oauth.py— W292 missing trailing newlineruff formatalso reflowed two short multi-line calls infreewheel_adapter.py(joined onto single lines under the line-length limit) and re-wrapped one call infreewheel_oauth.py. No logic changes — purely cosmetic.Why this matters
PR #15 (ar-r82f.16) fixes the seller CI workflow so Polly's QA verification can run pytest. With main's Lint job currently failing, the workflow short-circuits before verification can complete. Merging this restores green Lint on main and unblocks #15's verification path.
Verification
uvx ruff check src/ad_seller/clients/freewheel_*.py—All checks passed!uvx ruff check src/—All checks passed!git diffconfirms changes are scoped to the 2 freewheel files only (16 line changes total)Test plan