Skip to content

gtep_data.py bug and hardcoding fix#61

Merged
blnicho merged 36 commits into
IDAES:mainfrom
belle-storm:remove_hardcoding_gtep_data-(#60)
Apr 27, 2026
Merged

gtep_data.py bug and hardcoding fix#61
blnicho merged 36 commits into
IDAES:mainfrom
belle-storm:remove_hardcoding_gtep_data-(#60)

Conversation

@belle-storm
Copy link
Copy Markdown
Collaborator

@belle-storm belle-storm commented Mar 2, 2026

Fixes #60

@belle-storm belle-storm self-assigned this Mar 2, 2026
merge dev_testing branch into hardcoding to combine working branches
@belle-storm belle-storm changed the title [WIP] gtep_data.py bug and hardcoding fix gtep_data.py bug and hardcoding fix Mar 26, 2026
@belle-storm belle-storm requested a review from rundxdi March 26, 2026 22:50
@belle-storm
Copy link
Copy Markdown
Collaborator Author

Ready for review

@blnicho
Copy link
Copy Markdown
Member

blnicho commented Apr 20, 2026

@belle-storm could you fix the merge conflicts that arose from merging #72? I think you just have to modify the prepare_model_and_cost_data function in test_gtep_model.py to pass the arguments you need to read_debug_model.

Comment thread gtep/gtep_data.py
Comment thread gtep/gtep_data.py Outdated
Comment thread gtep/gtep_data.py Outdated
Comment thread gtep/gtep_data.py Outdated
@rundxdi
Copy link
Copy Markdown
Contributor

rundxdi commented Apr 26, 2026

@belle-storm could you fix the merge conflicts that arose from merging #72? I think you just have to modify the prepare_model_and_cost_data function in test_gtep_model.py to pass the arguments you need to read_debug_model.

If this has been resolved, I think we can go ahead and merge this

@blnicho blnicho merged commit a0814d3 into IDAES:main Apr 27, 2026
18 checks passed
@belle-storm belle-storm deleted the remove_hardcoding_gtep_data-(#60) branch April 28, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoding in gtep_data.py

3 participants