Skip to content

Settings: enable the system to run in submodule#2761

Merged
sudip-khanal merged 2 commits into
developfrom
fix/git-metadata-in-submodule
Jun 15, 2026
Merged

Settings: enable the system to run in submodule#2761
sudip-khanal merged 2 commits into
developfrom
fix/git-metadata-in-submodule

Conversation

@frozenhelium

@frozenhelium frozenhelium commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Make git metadata reads optional at startup
  • Make compose .env optional and overridable

@frozenhelium frozenhelium requested a review from thenav56 June 11, 2026 01:10
thenav56
thenav56 approved these changes Jun 11, 2026
View reviewed changes

@thenav56 thenav56 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's add a TODO to add a django check to show warning for fallback values

@sudip-khanal sudip-khanal merged commit 9c4ad59 into develop Jun 15, 2026
3 checks passed
@sudip-khanal sudip-khanal deleted the fix/git-metadata-in-submodule branch June 15, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thenav56 thenav56 thenav56 approved these changes

@sudip-khanal sudip-khanal sudip-khanal approved these changes

Assignees

@thenav56 thenav56

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frozenhelium @thenav56 @sudip-khanal