fix(security): reject pickled update_weights payloads by default#4765
Open
Solaris-star wants to merge 1 commit into
Open
fix(security): reject pickled update_weights payloads by default#4765Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
POST /update_weights previously accepted base64 pickle in serialized_named_tensors and deserialized it with ForkingPickler.loads before validation. On an unauthenticated api_server this is remote code execution. Reject string/list-of-string pickle payloads on the HTTP endpoint, and gate remaining engine-side pickle loads behind LMDEPLOY_ALLOW_PICKLE_UPDATE_PARAMS=1 for trusted local IPC only. Fixes InternLM#4698 Signed-off-by: Solaris-star <820622658@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /update_weightsacceptedserialized_named_tensorsas a base64 pickle string and deserialized it withForkingPickler.loads(native pickle) before any tensor validation. With the default unauthenticatedapi_serverbound to0.0.0.0, this is unauthenticated RCE.Changes
api_server.py): rejectstr/list[str]pickle payloads with HTTP 400; only structured dict/list tensors are accepted over the public endpoint.LMDEPLOY_ALLOW_PICKLE_UPDATE_PARAMS=1so trusted local IPC can still opt in; default is deny.Testing
Fixes #4698