fix: replace DC string comparisons with enums#1246
Merged
Conversation
baltzell
changed the title
baltzell
changed the title
baltzell
force-pushed
the
dc-remove-strings
branch
2 times, most recently
from
279b30f to
3e05ddd
Compare
baltzell
changed the title
baltzell
force-pushed
the
dc-remove-strings
branch
from
9b30f93 to
8d35f45
Compare
baltzell
force-pushed
the
dc-remove-strings
branch
2 times, most recently
from
22a9ffd to
c3d8aa2
Compare
tongtongcao
previously approved these changes
May 15, 2026
baltzell
force-pushed
the
dc-remove-strings
branch
from
c3d8aa2 to
e507b96
Compare
tongtongcao
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
targeted based on cpu flamegraphs from asprof