Protocol-based single stub file for submodules#353
Draft
Conversation
This commit adds a new specification document (docs/submodule.md) that describes how to represent PyO3 submodules in Python stub files. Key changes: - Protocol-based representation: Submodules are represented as typed attributes using typing.Protocol, not as separate importable modules - Single stub file generation: One .so file → one .pyi file for all layouts (Pure Rust and Mixed Python/Rust) - Unique protocol naming: Each submodule gets a unique protocol name (e.g., _SubMod1Protocol, _SubMod2Protocol) to avoid naming conflicts - Alignment with runtime behavior: Accurately reflects PyO3's module structure where submodules are attributes This specification addresses issue #351 and simplifies the stub generation strategy by eliminating the multi-file generation mechanism. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #351