GLSL_QCOM_multiple_wait_queues#4250
Open
wooyoungqcom wants to merge 1 commit into
Open
Conversation
|
|
wooyoungqcom
force-pushed
the
GLSL_QCOM_multiple_wait_queues
branch
2 times, most recently
from
1ba01bb to
658e89c
Compare
7 tasks
wooyoungqcom
force-pushed
the
GLSL_QCOM_multiple_wait_queues
branch
from
658e89c to
14990ce
Compare
| %parse-param {glslang::TParseContext* pParseContext} | ||
| %lex-param {parseContext} | ||
| %pure-parser // enable thread safety | ||
| %define api.pure // enable thread safety |
Contributor
There was a problem hiding this comment.
The bison documentation says this should be %define api.pure full but apparently it doesn't make a difference with the current version of bison.
There was a problem hiding this comment.
What do you want me to do? My local bison complained about it.
Contributor
There was a problem hiding this comment.
I think the change you have in the PR is fine.
| operands.push_back(loopNode.getPartialCount()); | ||
| } | ||
| } | ||
| if (loopNode.getMultipleWaitQueuesQCOM() != loopNode./*TIntermLoop::*/noMultipleQaitQueues) { |
Contributor
There was a problem hiding this comment.
Commented out code, you should remove it.
arcady-lunarg
requested changes
Jun 19, 2026
| if (it->size() == 0) | ||
| loop->setMultipleWaitQueuesQCOM(0); | ||
| else | ||
| if (positiveSignedArgument("multiple_wait_queuesQCOM", value)) |
Contributor
There was a problem hiding this comment.
I think this will silently fail for non-positive arguments. You need to include handling for that case and tests to exercise it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.