[gn] Only run glslang_extension_headers in default toolchain#4303
Draft
aidanwolter3 wants to merge 1 commit into
Draft
[gn] Only run glslang_extension_headers in default toolchain#4303aidanwolter3 wants to merge 1 commit into
aidanwolter3 wants to merge 1 commit into
Conversation
Wrap the `glslang_extension_headers` action so it only runs in the default toolchain. For other toolchains, define it as a group that redirects to the default toolchain version. This avoids duplicate execution of the action across different toolchains.
Contributor
Author
|
@arcady-lunarg is this your wheel house? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the
glslang_extension_headersaction so it only runs in thedefault toolchain. For other toolchains, define it as a group that
redirects to the default toolchain version. This avoids duplicate
execution of the action across different toolchains.