Calling an image from absolute URL prevents Eleventy to build#410
Open
teotimepacreau wants to merge 1 commit intoKiwiKilian:mainfrom
Open
Calling an image from absolute URL prevents Eleventy to build#410teotimepacreau wants to merge 1 commit intoKiwiKilian:mainfrom
teotimepacreau wants to merge 1 commit intoKiwiKilian:mainfrom
Conversation
Owner
|
Thanks for your contribution. What exactly do you mean by absolute URL? Pathes to local image files? Did you see #36? |
Author
|
distant URLs containing the image, as documented on the satory dependency |
Owner
|
Here in the comments you say it crashes, while in the added docs you talk about performance. Could you please first provide a reproduction of your issue? Then we can precisely decide, what piece of info is missing in the docs. For me using an image from an URL works totally fine, e.g.: <img src="https://picsum.photos/200/300" style="width: 200px; height: 300px;" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eleventy > v3.1.2 is causing eleventy-plugin-og-image to crash during Eleventy build in the case where
<img>in og-image.og.njk is calling an absolute URL (as required by Satory depency).Calling a base 64 img avoids the crash