Skip to content

fix(layout): push #footer to viewport bottom on content-short pages #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edgarcosta merged 2 commits into from
May 29, 2026
+19 −1
Merged

fix(layout): push #footer to viewport bottom on content-short pages #7016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e50a22
fix(layout): push #footer to viewport bottom on content-short pages
edgarcosta May 18, 2026
55c8c2e
Merge branch 'main' into fix/footer-bottom-on-short-pages
edgarcosta May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lmfdb/templates/homepage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
{% endmacro %}

{% block body -%}
<div id="layout">
<div id="page-wrapper">
<div id="header">
<div id="logo"><a href="{{ url_for('index') }}">
{% if ALPHA %}
Expand Down Expand Up @@ -230,6 +232,8 @@ <h2>{{ KNOWL_INC(KNOWL_ID+'.bottom', title='Additional information') }}</h2>
</div>
{% endif %}

</div>{# /#page-wrapper #}

<div id="footer">
{% if credit -%}
Data computed by {{ credit|safe }}.<br />
Expand Down Expand Up @@ -260,6 +264,7 @@ <h4 style="margin:5px;">{{shortthanks|safe}}</h4>
{{ version|safe }}
</div>
</div>
</div>{# /#layout #}



Expand Down
15 changes: 14 additions & 1 deletion lmfdb/templates/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,20 @@ body {
color: {{color.body_text}};
background-color: {{color.body_background}};
}

/* Sticky-footer scaffold: viewport-tall flex column wrapping the page
content + footer. Lives on a dedicated wrapper (not body) so that
third-party scripts that append to body (e.g. reCAPTCHA) do not
become extra flex items that can push the footer off the viewport. */
#layout {
display: flex;
flex-direction: column;
min-height: 100vh;
}

#page-wrapper {
flex: 1 0 auto;
}
td.title {
color: {{color.box_tab_text}};
}
Expand Down Expand Up @@ -301,7 +315,6 @@ body.knowl #header {
#main {
margin: 0px 0px 0px 184px;
padding: 0px 0px 0px 10px;
min-height: 600px;
}

.debug {
Expand Down
Loading