Fix #6900 - restructure layout of knowl boxes (more idiomatic CSS?)#7019
Merged
Conversation
havarddj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the layout problem from #6900 on all pages.
TLDR:
Before
After
Actually, this is not as simple as tacking on
overflow: hidden;to the knowl div, since currently the footer and header (e.g. "permalink" at the bottom) were placed inside the border of the knowl div by specifying the number of pixels to push by. This made settingoverflow: hiddencreate a weird scroll bar.The fix is to treat the dark gray area as a part of the knowl box itself, not as a border. So I set the border width to 0, colored the existing container div the same color as the border, and then gave the text div the brighter background color (and suitable margins). That way all the elements inside the div box are positioned in a reasonable way, and setting
overflow: hiddenworks as intended.