Skip to content

[ONEM-44272] Add logs to measure GC time #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcin-mielczarczyk-red wants to merge 1 commit into
base: lgi-wpe-2.38-25Q4
Choose a base branch
from
Open

[ONEM-44272] Add logs to measure GC time #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions Source/WebCore/page/MemoryRelease.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,20 @@ static void releaseCriticalMemory(Synchronous synchronous, MaintainBackForwardCa
#endif

if (synchronous == Synchronous::Yes) {
GCController::singleton().deleteAllCode(JSC::DeleteAllCodeIfNotCollecting);
GCController::singleton().garbageCollectNow();
{
auto t0 = std::chrono::steady_clock::now();
GCController::singleton().deleteAllCode(JSC::DeleteAllCodeIfNotCollecting);
auto t1 = std::chrono::steady_clock::now();
WTFLogAlways("[MemoryRelease] deleteAllCode: %lld ms",
std::chrono::duration_cast<std::chrono::milliseconds>(t1 - t0).count());
}
{
auto t0 = std::chrono::steady_clock::now();
GCController::singleton().garbageCollectNow();
auto t1 = std::chrono::steady_clock::now();
WTFLogAlways("[MemoryRelease] garbageCollectNow: %lld ms",
std::chrono::duration_cast<std::chrono::milliseconds>(t1 - t0).count());
}
} else {
#if PLATFORM(IOS_FAMILY) || PLATFORM(BROADCOM)
GCController::singleton().garbageCollectNowIfNotDoneRecently();
Expand Down Expand Up @@ -245,11 +257,21 @@ void jettisonExpensiveObjectsOnTopLevelNavigation()
const bool shouldJettison = (timeOfLastNavigation == now) || (std::chrono::duration_cast<std::chrono::seconds>(now - timeOfLastNavigation) >= minimumTimeSinceNavigation);
timeOfLastNavigation = now;

if (!shouldJettison)
if (!shouldJettison) {
WTFLogAlways("[MemoryRelease] jettisonExpensiveObjectsOnTopLevelNavigation: skipped");
return;
}

RunLoop::main().dispatch([]{
WTFLogAlways("[MemoryRelease] jettisonExpensiveObjectsOnTopLevelNavigation: dispatching releaseMemory");
auto dispatchTime = std::chrono::steady_clock::now();
RunLoop::main().dispatch([dispatchTime]{
auto t0 = std::chrono::steady_clock::now();
WTFLogAlways("[MemoryRelease] releaseMemory started (queued for %lld ms)",
std::chrono::duration_cast<std::chrono::milliseconds>(t0 - dispatchTime).count());
releaseMemory(Critical::Yes, Synchronous::Yes);
auto t1 = std::chrono::steady_clock::now();
WTFLogAlways("[MemoryRelease] releaseMemory finished (total %lld ms)",
std::chrono::duration_cast<std::chrono::milliseconds>(t1 - t0).count());
});
}
void registerMemoryReleaseNotifyCallbacks() { }
Expand Down