Skip to content

Update displaying top 3 most used languages with those percent#58

Open
luminous037 wants to merge 2 commits into
LuciNyan:mainfrom
luminous037:dev
Open

Update displaying top 3 most used languages with those percent#58
luminous037 wants to merge 2 commits into
LuciNyan:mainfrom
luminous037:dev

Conversation

@luminous037
Copy link
Copy Markdown

  • Added .ts file to utils to calculate the percentage of top languages.

  • Added stat and style codes for displaying top languages to the stats.ts and github-stats.tsx files.

  • I used the &hide=topLanguages option to hide the top languages stat, just like the other stats.

  • test image

image
  • test without avatar
image
  • hide top languages
image

@luminous037 luminous037 requested a review from LuciNyan as a code owner May 30, 2025 03:21
@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2025

@luminous037 is attempting to deploy a commit to the lucinyan's projects Team on Vercel.

A member of the Team first needs to authorize it.

@luminous037
Copy link
Copy Markdown
Author

@LuciNyan
The test code was originally based on the previous version of the project. Since I’ve made some modifications, would you like me to update the test code accordingly and send another PR?

@LuciNyan
Copy link
Copy Markdown
Owner

LuciNyan commented Jun 4, 2025

Hi @luminous037 !

I suggest we avoid modifying existing unit tests and instead focus on adding new ones. Changing current tests could impact users who are already using pixel-profile, as they might not expect to see "top lang" in the generated images.

Additionally, I’ve noticed that the display of "top lang" in the generated images feels a bit visually crowded from a layout perspective. It might be worth considering a redesign of the template to improve the overall visual effect.

@LuciNyan
Copy link
Copy Markdown
Owner

LuciNyan commented Jun 4, 2025

I’m currently working on a new template to better accommodate the display of "top lang," but I haven’t yet found a layout I’m fully satisfied with. Here’s how it looks so far. I’d love to hear your thoughts and any suggestions you might have! 🚀

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants