Skip to content

fix(thinc): restore ln2/f_log_cosh to keep AMD omptarget module-data layout #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbryngelson wants to merge 2 commits into from
+19 −1

fix(thinc): restore ln2 + f_log_cosh to keep AMD omptarget module-dat…

b6a7f4c
Select commit
Loading
Failed to load commit list.
Closed

fix(thinc): restore ln2/f_log_cosh to keep AMD omptarget module-data layout #1416

fix(thinc): restore ln2 + f_log_cosh to keep AMD omptarget module-dat…
b6a7f4c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 10, 2026 in 0s

64.96% (target 1.00%)

View this Pull Request on Codecov

64.96% (target 1.00%)

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.96%. Comparing base (3ac6f68) to head (b6a7f4c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   64.94%   64.96%   +0.01%     
==========================================
  Files          72       72              
  Lines       18861    18871      +10     
  Branches     1570     1571       +1     
==========================================
+ Hits        12250    12259       +9     
  Misses       5638     5638              
- Partials      973      974       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov