expr: canonicalize round_numeric output to remove negative zero#36655
Open
def- wants to merge 1 commit into
Open
expr: canonicalize round_numeric output to remove negative zero#36655def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
`dec::Context::round` preserves the sign bit when a negative fractional value rounds to zero, producing `-0` from e.g. `round(-0.4)`. Numeric row encoding includes the sign bit, so the unmunged result diverges from `0` under bytewise row identity (DISTINCT, UNION, GROUP BY, joins) even though decimal `=` treats them as equal, and the text cast renders the value as `-0`. Run `munge_numeric` after rounding, matching every other scale-changing op in this file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dec::Context::roundpreserves the sign bit when a negative fractional value rounds to zero, producing-0from e.g.round(-0.4). Numeric row encoding includes the sign bit, so the unmunged result diverges from0under bytewise row identity (DISTINCT, UNION, GROUP BY, joins) even though decimal=treats them as equal, and the text cast renders the value as-0.Run
munge_numericafter rounding, matching every other scale-changing op in this file.