expr: fix date_bin off-by-one for sources exactly on a bin boundary before origin#36661
Open
def- wants to merge 1 commit into
Open
expr: fix date_bin off-by-one for sources exactly on a bin boundary before origin#36661def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
…efore origin When `source < origin` and `tm_diff` was an exact multiple of the stride, the unconditional `tm_delta -= stride_ns` shifted the result back a whole extra bin. Also use `checked_sub` so that the `i64::MIN` nanosecond boundary surfaces `DateBinOutOfRange` instead of silently wrapping. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
source < originandtm_diffwas an exact multiple of the stride, the unconditionaltm_delta -= stride_nsshifted the result back a whole extra bin. Also usechecked_subso that thei64::MINnanosecond boundary surfacesDateBinOutOfRangeinstead of silently wrapping.