feat: add group.status - #9104
Open
ccharly wants to merge 12 commits into
Open
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 34f2bcb. Configure here.
| groupIndex, | ||
| groupState, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Alignment asserts missing gap groups
High Severity
#alignAccountsForRange now asserts each index already has a service group before applying alignment state, but alignment still builds account state for indices treated as unaligned when no group exists. Wallets can have non-contiguous group indices after init, so alignment can throw instead of creating or updating the missing group.
Reviewed by Cursor Bugbot for commit 34f2bcb. Configure here.
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding a new
group.statusin the account-tree, so the UI can use this information to show loading spinner when a group is not fully-aligned.References
N/A
Checklist
Note
Medium Risk
Breaking account-tree messenger and state shape changes affect all consumers; alignment/status timing is user-facing but covered by new tests and mirrors existing wallet status patterns.
Overview
Adds per-group alignment status end-to-end so the UI can show spinners while a multichain account group is creating or aligning accounts.
multichain-account-serviceintroducesMultichainAccountGroupStatusand tracks it onMultichainAccountGroup(uninitialized, in-progress variants,aligned,misaligned). Status updates publishMultichainAccountService:groupStatusChange. Alignment and post-creation flows run group updates insidewithState, which sets in-progress status and finalizes to aligned/misaligned without clobbering an outer in-progress state.account-tree-controller(breaking) adds requiredstatusonAccountGroupMultichainAccountObject. On tree build it reads wallet/group status fromgetMultichainAccountWallet/getMultichainAccountGroup(defaultuninitializedif missing) instead of hardcoding walletready. It subscribes toMultichainAccountService:groupStatusChangeto keep group status in sync. Messenger types now require the new event plus the get actions.Exports
isMultichainAccountGroupandisMultichainAccountWallettype guards for safer branching in insert/sync paths.Reviewed by Cursor Bugbot for commit 1b28dcd. Bugbot is set up for automated code reviews on this repo. Configure here.