ci: Add missing permissions to update-pull-request workflow#4031
Open
Mrtenz wants to merge 2 commits into
Open
ci: Add missing permissions to update-pull-request workflow#4031Mrtenz wants to merge 2 commits into
Mrtenz wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 853b7c5. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4031 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 425 425
Lines 12364 12364
Branches 1948 1948
=======================================
Hits 12189 12189
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
update-pull-requestworkflow is missingid-token: writepermission to perform OIDC token exchange.Note
Low Risk
CI workflow permission scoping only; no runtime application or data-path changes.
Overview
Adds explicit GitHub Actions
permissionsso the update-pull-request flow can use OIDC withMetaMask/github-tools/.github/actions/get-tokenand runghagainst PRs without relying on overly broad defaults.In
main.yml, the Dependabotupdate-pull-requestreusable-workflow call now passescontents: read,id-token: write, andpull-requests: readinto the child workflow.In
update-pull-request.yml, a workflow default ofcontents: readis set,is-fork-pull-requestgetspull-requests: readforgh pr view, and every job that callsget-token(react-to-comment,prepare, dedupe/build/LavaMoat/examples, andcommit-result) declaresid-token: write(withcontents: readwhere checkout/token exchange needs it).Reviewed by Cursor Bugbot for commit 4b9a10d. Bugbot is set up for automated code reviews on this repo. Configure here.