This repository was archived by the owner on Feb 18, 2026. It is now read-only.
fix(Request): forward Buffer & string payloads again#91
Open
pakerfeldt wants to merge 1 commit intoNRCHKB:devfrom
Open
fix(Request): forward Buffer & string payloads again#91pakerfeldt wants to merge 1 commit intoNRCHKB:devfrom
pakerfeldt wants to merge 1 commit intoNRCHKB:devfrom
Conversation
This is a regression in NRCHKB#74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
PR #74 added a type‑safety guard to src/nodes/Request.ts:
The guard works for JSON endpoints, but it silently drops every UniFi endpoint that returns raw bytes or plain text — most notably the Protect /snapshot thumbnails that are requested with
responseType: 'arraybuffer'.Since those thumbnails are delivered as Node Buffers, downstream flows never see them.
What this PR does
UnifiResponsetyping for all JSON endpoints.fixes #90