Skip to content

increasing precision tolerance #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francesco-bertolotti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

increasing precision tolerance #3060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/pytorch/attention/test_kv_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,13 @@ def get_tols(config, module, backend, dtype):
torch.bfloat16: (1.2e-1, 1e-1),
}
else:
# head_dim > 128 in fp16 is the worst case for accumulated rounding, and the
# full-sequence vs incremental-KV-cache paths use different kernels/mask types.
# On sm80 with older cuDNN the agreement grazes 1e-2 on a single element, so the
# fp16 tolerance is widened slightly. Tolerances were originally calibrated on
# Hopper/Blackwell + newer cuDNN.
tols = {
torch.half: (1e-2, 1e-2),
torch.half: (1.5e-2, 1.5e-2),
torch.bfloat16: (8e-2, 7e-2),
}
if module == "DotProductAttention":
Expand Down