Changes needed for CAM computing enthalpy -> mediator -> BLOM#675
Merged
TomasTorsvik merged 11 commits intoOct 14, 2025
Conversation
…atmosphere (based on implementation of Thomas Toniazzo).
Fix bugs for Boder CL parameter and woa_nuopc test
Bugfix for ERI test
mvertens
requested review from
JorgSchwinger,
TomasTorsvik,
jmaerz,
matsbn and
milicak
as code owners
TomasTorsvik
approved these changes
Oct 8, 2025
Contributor
TomasTorsvik
left a comment
TomasTorsvik
left a comment
There was a problem hiding this comment.
I'm not able to review this in detail, but I assume the general idea here is that BLOM should be able to receive fields coming from CAM, but that there should not be any changes in the BLOM state.
This was referenced Oct 9, 2025
Contributor
|
Thanks, @mvertens! One thing that I expect would fail when merging with the current master is the call to |
Contributor
Author
|
@matsbn @TomasTorsvik - testing on this PR showed bfb results with noresm3_0_beta03a - so I think this PR is ready at this point. |
Contributor
Author
|
@matsbn - yes this should be able to be merged independently. |
Contributor
|
I can merge this. |
github-project-automation
Bot
moved this from In Progress
to Done
in NorESM Development
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR superceded PR #618
With this PR, enthalpy flux as required for energy consistency with atmospheric water exchange is added to the non-solar heat flux field. Various methods for distributing the enthalpy flux components are available, and the current (hard-coded) method distributes the total enthalpy flux evenly over the sea-ice free ocean domain. This is based on an implementation of Tomas Toniazzo.
BLOM receives a new config variable-
component_computes_enthalpy_flux- in the NUOPC cap and if this variable isatmthen BLOM that triggers the receiving of enthalpy from CAM via the mediator. If this isnonethen enthalpy fluxes will not be received from the mediator.Testing:
This PR does not effect stand-alone BLOM tests. Tested that aux_blom_noresm compared successfully versus noresm3_0_beta03a baselines (using CMEPS PR below).
For the enthalpy configuration to be triggered
`component_computes_enthalpy_flux = 'atm'