Fix UnsupportedOperationException in executeAdminDomainCommand for postBootCommands with arguments#37
Open
jcputney wants to merge 1 commit intoOmniFish-EE:mainfrom
Conversation
…stBootCommands with arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36.
Problem
executeAdminDomainCommandmutates its caller-suppliedargslist viaargs.add(config.getDomain()). Callers fromstart()(post-boot-commands loop) andstop()/stopContainer()pass immutable lists fromArrays.asList(...)andList.of(), so this throwsUnsupportedOperationExceptionat runtime — surfacing most visibly at@AfterSuiteteardown.Fix
Defensive copy of
argsinsideexecuteAdminDomainCommand. The method no longer mutates caller state, and immutable inputs work as expected.Tests
Adds
GlassFishServerControlPostBootCommandsTestwith three cases covering both immutable list flavors (Arrays.asList,List.of). Verified to fail withUnsupportedOperationExceptionwithout the fixand pass with it.
Scope
One-line behavior change + targeted unit test. No reformatting, no unrelated edits.