Skip to content

refactor: route identifier reads through OneSignalIdentifiers #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 5 commits into from
Jun 2, 2026

refactor: drop redundant OSNotificationsManager pushSubscriptionId cache

0789138
Select commit
Loading
Failed to load commit list.
Merged

refactor: route identifier reads through OneSignalIdentifiers #1667

refactor: drop redundant OSNotificationsManager pushSubscriptionId cache
0789138
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 30, 2026 in 18m 48s

Code review found 1 important issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj:1982-1985 Missing OneSignalOSCore dep in podspecs/Package.swift

Annotations

Check failure on line 1985 in iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

See this annotation in the file changed.

@claude claude / Claude Code Review

Missing OneSignalOSCore dep in podspecs/Package.swift 

This PR adds `OneSignalOSCore.framework` to the link phase of the OneSignalExtension and OneSignalNotifications targets (pbxproj lines 1985, 2070) and the implementations now reference `OneSignalIdentifiers` from those binaries, but none of the package manifests declare the new dependency. Customers using the standard NSE integration (CocoaPods `OneSignalXCFramework/OneSignalExtension` or SPM `OneSignalExtension` product) will not get OneSignalOSCore.framework embedded into their NSE target, so
View more details on Claude