Enhance print_socket error handling and update Dbus error return for frontend error display#59
Merged
tillkamppeter merged 14 commits intoOpenPrinting:masterfrom Mar 19, 2026
Merged
Conversation
…ket and add cupsFreeOptions and g_free for failure return paths
…ups for better job creation feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pass CUPS error reason through D-Bus for frontend to display on job failure
Add error_msg output parameter to print_socket() so that the exact
CUPS error string from cupsLastErrorString() is captured on failure
and passed back to the caller. on_handle_print_socket() then includes
this string in the D-Bus error reply instead of a generic message,
allowing the frontend to display the actual reason for the failure
to the user (e.g. "job not created: Unauthorized").