Skip to content

Rename operational point fields for the international format#16799

Open
ppitou wants to merge 13 commits into
devfrom
akz/rename_operational_point_fields
Open

Rename operational point fields for the international format#16799
ppitou wants to merge 13 commits into
devfrom
akz/rename_operational_point_fields

Conversation

@ppitou
Copy link
Copy Markdown
Contributor

@ppitou ppitou commented May 19, 2026

Closes #16522
Closes #16519

Warning

The backend part of this PR is done and ready for review, the front part is still in progress

For the international format, the extensions have been flatten and some fields have been renamed:
Previous fields :

  • trigram is now main_code
  • ch is now secondary_code
  • ch_long_label is now secondary_name

New fields :

  • country_code : "FR" as example for the France
  • is_passenger_station as a boolean

@github-actions github-actions Bot added area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:core Work on Core Service area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services kind:api-change area:ui Work on UI labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

Changes in Schemas

Dear @ppitou, please ensure the following:

@ppitou ppitou force-pushed the akz/rename_operational_point_fields branch from 1c4cba6 to 32eb363 Compare May 19, 2026 14:54
@ppitou ppitou force-pushed the akz/rename_operational_point_fields branch from 32eb363 to 61448a7 Compare May 19, 2026 15:13
@ppitou ppitou force-pushed the akz/rename_operational_point_fields branch 2 times, most recently from e994758 to a9525e9 Compare May 19, 2026 15:25
@ppitou ppitou force-pushed the akz/rename_operational_point_fields branch from a9525e9 to 5a6d9be Compare May 19, 2026 15:49
@ppitou ppitou force-pushed the akz/rename_operational_point_fields branch from 5a6d9be to 845bfd3 Compare May 20, 2026 08:25
@ppitou ppitou requested a review from SaumonDesMers May 20, 2026 08:33
@DucNg DucNg force-pushed the akz/rename_operational_point_fields branch from 845bfd3 to ba26848 Compare May 20, 2026 08:51
@DucNg DucNg force-pushed the akz/rename_operational_point_fields branch from ba26848 to df8c3c6 Compare May 20, 2026 08:57
@DucNg DucNg linked an issue May 20, 2026 that may be closed by this pull request
@DucNg DucNg force-pushed the akz/rename_operational_point_fields branch from df8c3c6 to 56d0879 Compare May 20, 2026 09:01
@DucNg DucNg force-pushed the akz/rename_operational_point_fields branch from 31581d5 to 54b520e Compare May 28, 2026 13:52
Copy link
Copy Markdown
Member

@hhirtz hhirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

halfway through the front changes

Comment thread front/src/applications/stdcm/components/StdcmForm/StdcmLinkedTrainResults.tsx Outdated
Comment thread front/src/common/Map/Search/sortOperationalPoints.ts
Comment thread front/src/modules/pathfinding/components/Itinerary/ModalSuggestedVias.tsx Outdated
Comment thread editoast/src/views/search.rs Outdated
Copy link
Copy Markdown
Member

@hhirtz hhirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review for the rest of the front changes

Comment thread front/src/modules/timesStops/hooks/useTimesStopsColumns.tsx Outdated
Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts
Comment thread front/tests/pages/operational-studies/route-tab.ts Outdated
Comment thread front/tests/pages/operational-studies/route-tab.ts Outdated
ppitou and others added 8 commits May 29, 2026 10:31
For the international format, the extensions have been flatten and some fields have been renamed.

Previous fields :
	`trigram` is now `main_code`
	`ch` is now `secondary_code`
	`ch_long_label` is now `secondary_name`
New fields :
	`country_code` : "FR" as example for the France
	`is_passenger_station` as a boolean

Signed-off-by: Angelina Kuntz <angelina.kuntz@epita.fr>
Previous fields :
	`trigram` is now `main_code`
	`ch` is now `secondary_code`
	`ch_long_label` is now `secondary_name`
New fields :
	`country_code` : "FR" as example for the France
	`is_passenger_station` as a boolean

Signed-off-by: Duc Nguyen <nguyen@emersion.fr>

front: rename operational point fields

Previous fields :
	`trigram` is now `main_code`
	`ch` is now `secondary_code`
	`ch_long_label` is now `secondary_name`
New fields :
	`country_code` : "FR" as example for the France
	`is_passenger_station` as a boolean

Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
…ionMatcher.ts

Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
Comment thread front/public/locales/de/translation.json
Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts
@hhirtz
Copy link
Copy Markdown
Member

hhirtz commented May 29, 2026

Going through all the comments, those are still unresolved:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Work on Core Service area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:ui Work on UI kind:api-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

editoast: rename fields for PR international front: faire l'adaptations pour le modèle OperationalPoint

7 participants