Rename operational point fields for the international format#16799
Open
ppitou wants to merge 13 commits into
Open
Rename operational point fields for the international format#16799ppitou wants to merge 13 commits into
ppitou wants to merge 13 commits into
Conversation
Contributor
|
1c4cba6 to
32eb363
Compare
32eb363 to
61448a7
Compare
e994758 to
a9525e9
Compare
a9525e9 to
5a6d9be
Compare
5a6d9be to
845bfd3
Compare
845bfd3 to
ba26848
Compare
ba26848 to
df8c3c6
Compare
df8c3c6 to
56d0879
Compare
31581d5 to
54b520e
Compare
hhirtz
reviewed
May 28, 2026
Member
hhirtz
left a comment
There was a problem hiding this comment.
halfway through the front changes
hhirtz
reviewed
May 28, 2026
hhirtz
reviewed
May 28, 2026
Member
hhirtz
left a comment
There was a problem hiding this comment.
review for the rest of the front changes
For the international format, the extensions have been flatten and some fields have been renamed. Previous fields : `trigram` is now `main_code` `ch` is now `secondary_code` `ch_long_label` is now `secondary_name` New fields : `country_code` : "FR" as example for the France `is_passenger_station` as a boolean Signed-off-by: Angelina Kuntz <angelina.kuntz@epita.fr>
Previous fields : `trigram` is now `main_code` `ch` is now `secondary_code` `ch_long_label` is now `secondary_name` New fields : `country_code` : "FR" as example for the France `is_passenger_station` as a boolean Signed-off-by: Duc Nguyen <nguyen@emersion.fr> front: rename operational point fields Previous fields : `trigram` is now `main_code` `ch` is now `secondary_code` `ch_long_label` is now `secondary_name` New fields : `country_code` : "FR" as example for the France `is_passenger_station` as a boolean Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
…ionMatcher.ts Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
54b520e to
35c8f58
Compare
35c8f58 to
19ffd86
Compare
Signed-off-by: Duc Nguyen <nguyen@emersion.fr>
hhirtz
reviewed
May 29, 2026
hhirtz
reviewed
May 29, 2026
Member
|
Going through all the comments, those are still unresolved:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16522
Closes #16519
Warning
The backend part of this PR is done and ready for review, the front part is still in progress
For the international format, the extensions have been flatten and some fields have been renamed:
Previous fields :
trigramis nowmain_codechis nowsecondary_codech_long_labelis nowsecondary_nameNew fields :
country_code: "FR" as example for the Franceis_passenger_stationas a boolean