editoast: fix a couple issues in new authentication middlewares#16980
Draft
leovalais wants to merge 2 commits into
Draft
editoast: fix a couple issues in new authentication middlewares#16980leovalais wants to merge 2 commits into
leovalais wants to merge 2 commits into
Conversation
The middleware pushed in request extensions the user and the roles of the impersonator instead of the impersonated user. - Reworks and simplifies the flow of the middleware. - Fixes impersonation processing. - Adds a test for `/authz/me` to have a bit of impersonation coverage. - Adds a request extension `.impersonate`. - Removes useless referencing of `impl AsRef`. Signed-off-by: Léo VALAIS <leovalais+git@proton.me>
- Makes sure the user is created if it doesn't exist. - More consistent behavior when compared to other authentication modes. - Adds a test for `/authz/me` to inspect the behavior. Signed-off-by: Léo VALAIS <leovalais+git@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://github.com/osrd-project/osrd-confidential/issues/1168
To merge after #16281