work in progress: investigate mismatch errors#16983
Draft
eckter wants to merge 2 commits into
Draft
Conversation
This does fix several mismatch cases, but it's not always enough. The main issue it's trying to fix is some (likely) bug in the way we estimate the timed points when it's covered by several engineering allowance ranges.
Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just logging some stuff, I don't expect to have the time to finish and it might be interesting for someone else to take over.
(it doesn't have to be considering how much of a rough draft that is, this is more "could be useful to read" than "should be taken over")
The main issue is that we sometimes have "mismatch" errors (the ones described here. They can be reproduced by running several very long searches on dense timetables. They're rare on smaller path, but when going from Germany to Spain they happen in maybe 1/10 requests.
I logged a few of them and tried to see if an llm could figure it out. That's the first commit: it did identify some issues around the way we distribute overlapping engineering allowance when adding timed points. I did not proofread it, and it doesn't fix every case. There may be several different issues.
As I did spend a lot of time going through the generated space-time diagrams and the logs, I also tried to modify the logs to make them closer and more relevant. This proved a little harder than expected,
Unavailable.causesdoesn't really seem to match the chart. There's likely a bug either in these changes or in the way these causes are generated.