Remove required to see for polls#1428
Open
ostcar wants to merge 1 commit into
Open
Conversation
Member
Author
|
I implemented this chance in this PR for the new vote serivce: #1443 It will be a bit more difficult, to keep the current behavior in the new vote service. If you don't say anything about this, this change will be part of the new vote service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emanuelschuetze this is the change, we talked about. At the moment, a user can see the names of users, that have voted, even when the user does not have
user.can_see.I asked @normanjaeckel and he thinks, that it is not generally necessary to see the names of users, that have voted. There are cases, where this is necessary, but in this cases, its ok, to give the permission
user.can_see.@bastianjoel If I understand it correctly, the client already hided user-names in this cases.