-
Notifications
You must be signed in to change notification settings - Fork 50
Adding QUADCOIL integration to DESC as an objective #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 40 commits
e930a2e
69a5e87
74892d8
395d8f9
6426650
925e19e
773651e
c36d534
dc6a65e
45e88d8
f243182
59ec216
a7c368f
87c86e4
7e6d350
6507199
c4300f5
c4754d4
25e96af
3afd240
e47c443
8d8de33
b96e3db
18e82c0
a5455f8
1d0ff07
0ecd9f1
b6fea15
8fa750d
7b576d1
218ba1a
312c961
778f77b
39d5bea
06c74ff
702d446
1cfc920
66250f0
61c5c12
9faf614
fcd9cc1
cf3ad2b
13d3ad2
2ea1032
7dfc348
4090f6a
73a1afe
eaff201
90c862c
9871de1
887dfc0
4942d9d
d947a56
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,7 @@ def _make_hashable(x): | |
|
|
||
| def _unmake_hashable(x): | ||
| # turn tuple of ints and shape to ndarray | ||
| if isinstance(x, tuple) and x[0] == "ndarray": | ||
| if isinstance(x, tuple) and len(x) and x[0] == "ndarray": | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it hurts to have it, but why did you need this change?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default values for some QUADCOIL arguments are empty list/tuples (I had to do it because the adjoint derivative is wrapped in a vjp rule before handed to DESC and this way some flows are simpler). Without this check it breaks DESC Optimizable. |
||
| return np.array(x[2]).reshape(x[1]) | ||
| if isinstance(x, list): | ||
| return [_unmake_hashable(y) for y in x] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.