update comments#2242
Conversation
Added notes about a more performant version of the implementation.
rahulgaur104
left a comment
There was a problem hiding this comment.
Full optimization performance benchmarks were never performed. For example, when optimizing an equilibrium, the new bounce integral from ku/bounce (merged) took almost exactly the same time as the old bounce integration routines. So compute maybe faster but optimization definitely was not. Maybe sparse pullback will change that, maybe not.
I don't actually care at this point, so approving this PR.
@rahulgaur104 's comment purpose is not clear to me, nor why he feels the need to advertise he does not care. Focusing on the technical/work relevant content of that comment, his statements in reference to my work are verifiably false. To reduce spread of misinformation for others who are reading, note that
Next, ku/sparse_pullback (link: #2170 ) and the following PRs reduces memory and improves performance by a factor of the number of flux surfaces the optimization is done with.
I suggest making effort to become better informed before making negative claims on others' work. |
|
@YigitElma @ddudt @f0uriest @dpanici it still won't let me merge. Please click merge. |
Adds some comments to objectives