fix(vibe-check): make logo readable in dark mode#18164
Open
DerGeraetK wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
d683907 to
3bd0334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #17952
In dark mode on
/vibe-check, the PostHog logo in the "You'll hate PostHog if..." heading was nearly invisible: the Logo SVG letters use hardcoded black path fills that don't adapt to the theme.This applies the same theme-conditional fill already used for the Logo across the site (
About/v2/Letterhead.tsx,Home/Control,Home/Test,ko/_KoreanHome.tsx):fill={siteSettings.theme === 'dark' ? 'white' : undefined}undefinedfalls back to the component default — unchanged behavior.Note: open PR #17950 fixes the text contrast on this same page (#17926). This PR only touches the Logo fill — semantically independent, but both edit adjacent lines of the same
<h1>, so whichever lands second needs a trivial rebase. Happy to rebase if #17950 merges first.Screenshots (dark before → dark after → light unchanged)
Dark before:

Dark after:

Light unchanged:

Checklist
🤖 Agent context
components/Logo(hardcoded path fills), searched the repo for existing dark-mode Logo treatments and applied the established pattern rather than inventing one./vibe-check; Prettier/ESLint via the repo's commit hooks.