Adding regularization objective option to parmest#3550
Conversation
|
@djlaky @adowling2 Please provide early feedback |
|
UPDATE (07/15/25); Intended to be added AFTER Shammah's weighted SSE PR (#3535) and follow a similar format, adding another option for available objectives using Enums. Currently preparing for next stage of review |
|
@adowling2 @djlaky Made some edits to this finally. Meant to follow Shammah's layout in PR #3535, waiting to merge, currently some conflicts I cannot resolve on my end. Made it's own full objective instead of a term to add. Also added weighting term. Ready for next round of review. |
|
Will not be actively worked on before finalization of _Q_opt_blocks. Closing for now to resume in the future. |
|
@blnicho Thank you for fixing the formatting issue. I tried to resolve the merge conflict after _Q_opt and was not near my laptop. Both of the failing tests are not related to my tests. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01%
==========================================
Files 905 906 +1
Lines 107490 107638 +148
==========================================
+ Hits 96873 97000 +127
- Misses 10617 10638 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great point @slilonfe5. I am planning to add a few today. Also, is ParmEst at 81% or my change lines in this code? I think what it says here is my changes are at 81% but I could be wrong. |
Fixes # .
Summary/Motivation:
Currently, the only default objective is the standard SSE objective. This edit provides the capability to add a
regularization term to the SSE objective with a prior FIM and reference parameter values.
Changes proposed in this PR:
TODO before converting from draft
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: