Skip to content

A couple missing zero-derivs and an inplace rrule test for svd_trunc#448

Merged
kshyatt merged 5 commits into
mainfrom
ksh/svd_trunc
Jun 17, 2026
Merged

A couple missing zero-derivs and an inplace rrule test for svd_trunc#448
kshyatt merged 5 commits into
mainfrom
ksh/svd_trunc

Conversation

@kshyatt

@kshyatt kshyatt commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@kshyatt kshyatt requested a review from lkdvos June 10, 2026 12:04
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/TensorKitMooncakeExt/tensoroperations.jl 0.00% 7 Missing ⚠️
Files with missing lines Coverage Δ
ext/TensorKitMooncakeExt/utility.jl 71.42% <ø> (ø)
ext/TensorKitMooncakeExt/tensoroperations.jl 91.66% <0.00%> (-6.36%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread ext/TensorKitMooncakeExt/factorizations.jl
Comment thread test/mooncake/factorizations.jl Outdated
@kshyatt

kshyatt commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

OK well apparently this just works without the rules in TensorKit, pretty darn cool in my view.

@kshyatt kshyatt changed the title A couple missing zero-derivs and an inplace rrule for svd_trunc A couple missing zero-derivs and an inplace rrule test for svd_trunc Jun 17, 2026
@kshyatt kshyatt merged commit 848a3b4 into main Jun 17, 2026
42 of 43 checks passed
@kshyatt kshyatt deleted the ksh/svd_trunc branch June 17, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants