Skip to content

fix: mock players in studio local server dont have permissions to use cmdr #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daimywil wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: mock players in studio local server dont have permissions to use cmdr #602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf8f5e7
give permissions to players with negative userid
Daimywil Nov 4, 2025
48a970c
fixes
Daimywil Nov 14, 2025
c4809a7
removed comment
Daimywil Nov 14, 2025
10eddca
Merge branch 'main' into give-permissions-to-mock-players-in-studio-l…
Daimywil Nov 14, 2025
1333000
Merge branch 'main' into give-permissions-to-mock-players-in-studio-l…
Daimywil Nov 26, 2025
71662fe
Merge branch 'main' into give-permissions-to-mock-players-in-studio-l…
Quenty Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/permissionprovider/src/Server/Providers/CreatorPermissionProvider.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function CreatorPermissionProvider.PromiseIsPermissionLevel(
assert(PermissionLevelUtils.isPermissionLevel(permissionLevel), "Bad permissionLevel")

if permissionLevel == PermissionLevel.ADMIN or permissionLevel == PermissionLevel.CREATOR then
return Promise.resolved(player.UserId == self._userId or RunService:IsStudio())
return Promise.resolved(player.UserId == self._userId or RunService:IsStudio() or player.UserId < 0)
Comment thread
Daimywil marked this conversation as resolved.
Outdated
else
error("Unknown permissionLevel")
end
Expand Down
6 changes: 6 additions & 0 deletions src/permissionprovider/src/Server/Providers/GroupPermissionProvider.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ end
function GroupPermissionProvider._handlePlayer(self: GroupPermissionProvider, player: Player): ()
assert(player, "Bad player")

-- when testing with mock players in studio, their userids are negative
if player.UserId < 0 then
Comment thread
Daimywil marked this conversation as resolved.
Outdated
self._creatorCache[player.UserId] = true
return
end

self:_promiseRankInGroup(player):Then(function(rank)
if rank >= self._config.minAdminRequiredRank then
self._adminsCache[player.UserId] = true
Expand Down
Loading