You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change GetValues to TryGetValues in TextToSpeechEndpoint
The given header was not found
at System.Net.Http.Headers.HttpHeaders.GetValues(HeaderDescriptor descriptor)
at ElevenLabs.TextToSpeech.TextToSpeechEndpoint.<TextToSpeechAsync>d__7.MoveNext()
@alikberova what exactly is this trying to fix? We need this header since it gives us metadata about the history item id
the exception was The given header was not found coming from HttpHeaders.GetValues method.
This method throws error if the HistoryItemId header is missing.
Seems this behavior is not expected in the code flow giving that code is checking for IsNullOrWhiteSpace.
If the clipId is null, this if statement never be reached as GetValues throws exception.
var clipId = response.Headers.GetValues(HistoryItemId).FirstOrDefault();
if (string.IsNullOrWhiteSpace(clipId))
{
throw new ArgumentException("Failed to parse clip id!");
}
The fix ensures that, when the header is missing, the code throws the intended error message Failed to parse clip id! instead of the generic HttpHeaders exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change GetValues to TryGetValues in TextToSpeechEndpoint