[SVS] Refactor SVS element size calculations and block size handling#980
Open
rfsaliev wants to merge 4 commits into
Open
[SVS] Refactor SVS element size calculations and block size handling#980rfsaliev wants to merge 4 commits into
rfsaliev wants to merge 4 commits into
Conversation
… in SVS utilities
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
ethanglaser
reviewed
Jun 17, 2026
|
|
||
| cmake_dependent_option(SVS_SHARED_LIB "Use SVS pre-compiled shared library" ON "USE_SVS AND GLIBC_FOUND AND SVS_LVQ_SUPPORTED" OFF) | ||
| if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") | ||
| if(GLIBC_VERSION VERSION_GREATER_EQUAL "2.31" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "21.0") |
Collaborator
There was a problem hiding this comment.
Suggested change
| if(GLIBCXX_VERSION VERSION_GREATER_EQUAL "11") | |
| set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-reduced-clang21-gcc11-2026-06-17-1412.tar.gz" CACHE STRING "SVS URL") |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=======================================
Coverage 97.09% 97.10%
=======================================
Files 141 141
Lines 8164 8179 +15
=======================================
+ Hits 7927 7942 +15
Misses 237 237 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This pull request refactors and improves the way element sizes and block sizes are calculated and used in the SVS storage traits, enhancing clarity and modularity in the code. The changes introduce clearer separation between primary, residual, and secondary element sizes, update the block size calculation to use a new structure, and simplify related test logic.
Which issues this PR fixes
This PR fixes index size estimation issues for SVSIndex by using new
blocksize_elementsparameter introduced in intel/ScalableVectorSearch#344.TODO:
Main objects this PR modified
Mark if applicable