Skip to content

fix(failed_tests_file): correctly iterate testsFailed dict #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kei-nan merged 2 commits into from
May 29, 2026
Merged

fix(failed_tests_file): correctly iterate testsFailed dict #251

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
102e8b8
fix(failed_tests_file): correctly iterate testsFailed dict
kei-nan May 28, 2026
5806e03
address review: use .keys() to make intent explicit
kei-nan May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RLTest/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ def _get_result():
if self.testsFailed:
if self.args.failed_tests_file:
with open(self.args.failed_tests_file, 'w') as file:
for test, _ in self.testsFailed:
for test in self.testsFailed:
Comment thread
kei-nan marked this conversation as resolved.
Outdated
file.write(test.split(' ')[0] + "\n")

print(Colors.Bold('Failed Tests Summary:'))
Expand Down
Loading