Migrate CLN hold invoice plugin to Boltz hold#2503
Open
0xjc65eth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This migrates the CLN hold-invoice path from the archived
daywalker90/holdinvoiceplugin toBoltzExchange/hold.Changes included:
holdbinary in the CLN Docker imagehold-grpc-portand the new plugin binary nameBoltzExchange/holdproto inscripts/generate_grpc.shapi/lightning/cln.pyto the new gRPC API:Invoicefor hold invoice creationListfor invoice lookupSettlewith the payment preimageCancelwith the payment hashUNPAID/ACCEPTED/PAID/CANCELLEDstate mappingcltv_expiryfrom accepted invoice HTLCsCloses #2317.
Testing
python3 -m py_compile api/lightning/cln.py.venv/bin/ruff check api/lightning/cln.pyhold.protostubs withgrpc_tools.protocin/tmpand smoke-tested the Python API symbols used by this PRbash -n docker/cln/entrypoint.shsh -n scripts/traditional/regtest-nodesgit diff --checkI did not run a full CLN regtest/docker flow locally, so the main thing I would still want confirmed in review is the runtime plugin startup plus one accepted/settled hold invoice path.