fix: trim URL inputs and expand openai-compatible embedding model profiles#12367
Draft
roomote-v0[bot] wants to merge 1 commit into
Draft
fix: trim URL inputs and expand openai-compatible embedding model profiles#12367roomote-v0[bot] wants to merge 1 commit into
roomote-v0[bot] wants to merge 1 commit into
Conversation
…files - Add input trimming for URL and identifier fields in CodeIndexPopover handleSaveSettings to prevent leading/trailing whitespace from causing silent authentication failures (Bug 3 from #12366) - Expand openai-compatible model profiles with popular third-party embedding models (Qwen, BAAI BGE, Nomic, Mixedbread) for better auto-dimension detection (Bug 2 from #12366) - Add tests for new model dimension lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #12366. Feedback and guidance are welcome.
Changes
1. Input trimming for URL/identifier fields (Bug 3)
Added whitespace trimming in
CodeIndexPopover.handleSaveSettings()for:codebaseIndexQdrantUrlcodebaseIndexEmbedderBaseUrlcodebaseIndexOpenAiCompatibleBaseUrlcodebaseIndexEmbedderModelIdcodebaseIndexQdrantApiKeyThis prevents leading/trailing whitespace (e.g.
" https://api.featherless.ai/v1") from causing silent authentication failures.2. Expanded openai-compatible model profiles (Bug 2)
Added popular third-party embedding models to
EMBEDDING_MODEL_PROFILES["openai-compatible"]for auto-dimension detection:Users can still enter any custom model ID -- these profiles just enable automatic dimension detection for common models.
Note on Bug 1 (API key)
Bug 1 (missing API key field) was already fixed on
mainprior to this PR. ThecodebaseIndexOpenAiCompatibleApiKeyfield and its save/load logic already exist.Testing
Interactively review PR in Roo Code Cloud